Do away with HTTP server and instead used a Go based File server for hosting binaries #346
Conversation
Signed-off-by: Anand Francis Joseph <[email protected]>
…rfile Signed-off-by: Anand Francis Joseph <[email protected]>
Signed-off-by: Anand Francis Joseph <[email protected]>
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 58.61% 58.61%
=======================================
Files 57 57
Lines 2885 2885
=======================================
Hits 1691 1691
Misses 1028 1028
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wtam2018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 58.61% 58.61%
=======================================
Files 57 57
Lines 2885 2885
=======================================
Hits 1691 1691
Misses 1028 1028
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
The kam container image uses
httpdbase image which requires frequent updates for CVE fixes and is difficult to maintain. By using a Go based fileserver for hosting the binaries for different OS and architecture, we can do away with HTTP server and instead use a light weight image. Even ascratchbase image should be enough for running a go binary.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer: